viirya commented on PR #2360: URL: https://github.com/apache/arrow-rs/pull/2360#issuecomment-1209616992
> refactor the validation for decimal256 @viirya > almost 50x faster than before. You can get the benchmark code in the `decimal_validate.rs` file. Yea, I think for 256-bit decimal, current value validation is somehow inefficient. Comparing directly on bytes should be more efficient on 256-bit decimal. For 128-bit, I think that it won't be too much different than i128 comparison, maybe some marginal number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
