HaoYang670 commented on PR #2360: URL: https://github.com/apache/arrow-rs/pull/2360#issuecomment-1210044915
> Yea, I think for 256-bit decimal, current value validation is somehow inefficient. Comparing directly on bytes should be more efficient on 256-bit decimal. For 128-bit, I think that it won't be too much different than i128 comparison, maybe some marginal number. Another benefit we could get from this is that we can make the fn `validate_decimal_precision` more general. Currently, I put this function in `Decimal128Array` and `Decimal256Array` but not ``DecimalArray<BYTE_WIDTH>` because they use different `validate_decimal_precision` functions and have different APIs: https://github.com/apache/arrow-rs/blob/master/arrow/src/array/array_decimal.rs#L276-L283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
