ovr commented on code in PR #3037:
URL: https://github.com/apache/arrow-datafusion/pull/3037#discussion_r943935080
##########
datafusion/physical-expr/src/expressions/binary/kernels.rs:
##########
@@ -49,7 +50,7 @@ macro_rules! binary_bitwise_array_op {
/// like int64, int32.
/// It is used to do bitwise operation on an array with a scalar.
macro_rules! binary_bitwise_array_scalar {
Review Comment:
I've changed `binary_bitwise_array_scalar` to pass function as `expr` to do
casting, because `wrapping_shr` and `wrapping_shl` requires u32. I tried to do
it with ` let right: $TYPE = scalar.try_into().unwrap();` but I
found that it will show a error because it's not possible to cast all numeric
types to `u32`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
