ovr commented on code in PR #3037:
URL: https://github.com/apache/arrow-datafusion/pull/3037#discussion_r945348841
##########
datafusion/expr/src/binary_rule.rs:
##########
@@ -139,12 +139,14 @@ pub fn coerce_types(
fn bitwise_coercion(left_type: &DataType, right_type: &DataType) ->
Option<DataType> {
use arrow::datatypes::DataType::*;
- if !is_numeric(left_type) || !is_numeric(right_type) {
+ if !both_numeric_or_null_and_numeric(left_type, right_type) {
Review Comment:
<img width="739" alt="image"
src="https://user-images.githubusercontent.com/572096/184556700-a1668b74-0f4d-461d-a074-72c2d18f1e80.png";>
To be similar with default SQL behaviour for null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/572096/184556700-a1668b74-0f4d-461d-a074-72c2d18f1e80.png"](https://user-images.githubusercontent.com/572096/184556700-a1668b74-0f4d-461d-a074-72c2d18f1e80.png"){kind=link}