ovr commented on code in PR #3037:
URL: https://github.com/apache/arrow-datafusion/pull/3037#discussion_r945348702
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -2494,4 +2533,19 @@ mod tests {
assert_eq!(result.as_ref(), &expected);
Ok(())
}
+
+ #[test]
+ fn bitwise_shift_scalar_test() -> Result<()> {
+ let input = Arc::new(Int32Array::from(vec![Some(2), None, Some(4)]))
as ArrayRef;
+ let module = ScalarValue::from(10i32);
Review Comment:
Instead of doing unit test here, I did a simple SQL test which test the
whole pipeline, and I found that DF doesn't handle nulls for bitwise operators.
Fixed in:
https://github.com/apache/arrow-datafusion/pull/3037/commits/810f4b052c863a6a9d992a6eba1fd0e40f2c49d4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
