tustvold commented on code in PR #2711:
URL: https://github.com/apache/arrow-rs/pull/2711#discussion_r969656609
##########
arrow/src/pyarrow.rs:
##########
@@ -236,26 +236,3 @@ impl PyArrowConvert for ArrowArrayStreamReader {
Ok(PyObject::from(reader))
}
}
-
-macro_rules! add_conversion {
Review Comment:
I don't honestly understand why these are necessary, as they seem to overlap
with the functionality of PyArrowConvert. More specifically they can't be
implemented for DataType, etc... as these are now foreign types
##########
arrow/src/pyarrow.rs:
##########
@@ -236,26 +236,3 @@ impl PyArrowConvert for ArrowArrayStreamReader {
Ok(PyObject::from(reader))
}
}
-
-macro_rules! add_conversion {
Review Comment:
I don't honestly understand why these are necessary, as they seem to overlap
with the functionality of PyArrowConvert. More specifically FromPyObject and
IntoPy can't be implemented for DataType, etc... as these are now foreign types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
