tustvold commented on code in PR #2711: URL: https://github.com/apache/arrow-rs/pull/2711#discussion_r970062344
########## arrow-schema/src/error.rs: ########## @@ -0,0 +1,45 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Defines `ArrowSchemaError` for representing failures in arrow schema + +use std::error::Error; + +#[derive(Debug)] +pub enum ArrowSchemaError { Review Comment: Not disagreeing, in fact I totally agree, but if that is the case what is the value of having any error variants at all? I have no major objection to an arrow-error crate, but we would potentially lose the ability to define `From<csv::Error>`, etc... and it does seem a little odd... I don't like the error handling as it stands, but I was trying to avoid making major changes to it 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
