tustvold commented on code in PR #2711:
URL: https://github.com/apache/arrow-rs/pull/2711#discussion_r969824463
##########
arrow/src/pyarrow.rs:
##########
@@ -237,25 +237,25 @@ impl PyArrowConvert for ArrowArrayStreamReader {
}
}
-macro_rules! add_conversion {
- ($typ:ty) => {
- impl<'source> FromPyObject<'source> for $typ {
- fn extract(value: &'source PyAny) -> PyResult<Self> {
- Self::from_pyarrow(value)
- }
- }
+/// A newtype wrapper around a `T: PyArrowConvert` that implements
Review Comment:
This is a breaking change, but is necessary to get around the orphan rule
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
