vibhatha commented on code in PR #14143:
URL: https://github.com/apache/arrow/pull/14143#discussion_r972488479
##########
cpp/src/arrow/engine/substrait/extension_set.h:
##########
@@ -253,6 +253,20 @@ class ARROW_ENGINE_EXPORT ExtensionIdRegistry {
/// \return A converter function or an invalid status if no converter is
registered
virtual Result<SubstraitCallToArrow> GetSubstraitCallToArrow(
Id substrait_function_id) const = 0;
+
+ /// \brief Similar to \see GetSubstraitCallToArrow but only uses the name
+ ///
+ /// There may be multiple functions with the same name and this will return
+ /// the first. This is slower than GetSubstraitCallToArrow and should only
+ /// be used when the plan does not include a URI (or the URI is "/")
+ virtual Result<SubstraitCallToArrow> GetSubstraitCallToArrowFallback(
+ util::string_view function_name) const = 0;
+
+ /// \brief Similar to \see GetSubstraitAggregateToArrow but only uses the
name
+ ///
+ /// \see GetSubstraitCallToArrowFallback for details on the fallback behavior
+ virtual Result<SubstraitAggregateToArrow>
GetSubstraitAggregateToArrowFallback(
+ util::string_view function_name) const = 0;
Review Comment:
maybe?
```suggestion
const util::string_view& function_name) const = 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
