westonpace commented on code in PR #14143:
URL: https://github.com/apache/arrow/pull/14143#discussion_r972545813
##########
cpp/src/arrow/engine/substrait/extension_set.cc:
##########
@@ -519,6 +519,21 @@ struct ExtensionIdRegistryImpl : ExtensionIdRegistry {
return maybe_converter->second;
}
+ Result<SubstraitCallToArrow> GetSubstraitCallToArrowFallback(
+ util::string_view function_name) const override {
Review Comment:
`string_view` is effectively a "pointer" (well, a pointer and a size) and it
is small enough that it isn't worth passing by reference:
https://quuxplusone.github.io/blog/2021/11/09/pass-string-view-by-value/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
