tustvold commented on code in PR #2854: URL: https://github.com/apache/arrow-rs/pull/2854#discussion_r990798877
########## parquet/src/arrow/arrow_writer/byte_array.rs: ########## @@ -551,7 +551,10 @@ where match &mut encoder.dict_encoder { Some(dict_encoder) => dict_encoder.encode(values, indices), - None => encoder.fallback.encode(values, indices), + None => { + encoder.num_values += indices.len(); Review Comment: I'm guessing the problem was that whilst the estimated_data_page_size would increase, the lack of any values would cause it to erroneously not try to flush the page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org