tustvold commented on code in PR #2854:
URL: https://github.com/apache/arrow-rs/pull/2854#discussion_r990799861
##########
parquet/src/arrow/arrow_writer/byte_array.rs:
##########
@@ -551,7 +551,10 @@ where
match &mut encoder.dict_encoder {
Some(dict_encoder) => dict_encoder.encode(values, indices),
- None => encoder.fallback.encode(values, indices),
+ None => {
+ encoder.num_values += indices.len();
Review Comment:
Should we be doing this regardless of if we've fallen back? I think
currently this will fail to flush a dictionary encoded data page even if it has
reached sufficient size?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
