thinkharderdev commented on code in PR #2854:
URL: https://github.com/apache/arrow-rs/pull/2854#discussion_r990816906
##########
parquet/src/arrow/arrow_writer/byte_array.rs:
##########
@@ -551,7 +551,10 @@ where
match &mut encoder.dict_encoder {
Some(dict_encoder) => dict_encoder.encode(values, indices),
- None => encoder.fallback.encode(values, indices),
+ None => {
+ encoder.num_values += indices.len();
Review Comment:
I think it already does that right?
https://github.com/apache/arrow-rs/blob/2ae23093c3f7edc278fe6daf57daf167c430143b/parquet/src/arrow/arrow_writer/byte_array.rs#L313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
