rdettai commented on pull request #8300:
URL: https://github.com/apache/arrow/pull/8300#issuecomment-704940018


   Thanks a lot for your time and comments! 
   
   > using a more standard spelling of Chunk rather than Chunck
   
   You mean "a more correct spelling" 😉 
   
   > I wonder how important separating out `get_read` and `get_read_seek` is
   
   Right, I was just looking at this. There might be some simplifications that 
could be implemented here.
   
   > I think we should begin moving the parquet reader towards using Arc
   
   That is true, but there is a major problem with the way `FileSource` works 
in that case. The fact that we share a single file handle between instances 
(because it is the behavior of `File::clone()`) prevents us from accessing 
concurrently a same file.
   
   Give me a bit of time, I will try to fix these. I'll come back to you if I 
have further doubts. Thanks again !!!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to