rdettai commented on pull request #8300: URL: https://github.com/apache/arrow/pull/8300#issuecomment-707712589
I'm open to moving traits such as `ParquetReader` back to `reader.rs` or re-exposing them with `pub use crate::`. But I have the feeling these traits are very specific to the implementation of the `util::io::FileSource`, which is private because it is mainly a slicing/buffering wrapper around `File` (hence the name ;-)). This wrapper makes sense because File is cheap to clone and needs to be buffered, but this will not be generally the case for other implems of `ParquetReader`. What about your usecase @alamb ? Do you think it is worth it have the ChunkReader be implemented for `T:ParquetReader` rather than `File` ? This would be more flexible, maybe a little bit too much... It is a good observation that `TryClone` is also used in the writer. I didn't want to move things around in the writer because it would have made the PR even more massive and also because I've been told that there was an active development effort going on over there :-). Similar changes might apply. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
