alamb commented on pull request #8300: URL: https://github.com/apache/arrow/pull/8300#issuecomment-706546221
Sorry I don't have more time to spend on this -- I am still struggling to get my existing project code to compile against this branch and this PR is pretty massive to digest. One other thing I found this morning is that the `TryClone` trait is still used in `ParquetWriter` so I do think it needs to be publically exported somehow (or we need to refactor the writer) I have also been trying to figure out if the `ParquetReader` trait is still needed after this refactoring. So I guess all in all my conclusion is that the ideas behind this PR are good but: 1. It is hard to review given its size 2. There will likely be a fairly substantial backwards incompatible change for anyone using the ParquetReader in their project ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
