tustvold opened a new pull request, #3950:
URL: https://github.com/apache/arrow-datafusion/pull/3950
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #3538
Closes #3947
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
We don't want to require downstreams to install PROTOC, but we also don't
want to allow the generated code to get out of sync. This is the approach we
use with arrow-rs, and it appears to work fairly well. Specifically we don't
bundle the .proto files in the released crate, and only generate the code if
the .proto files exist.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
datafusion-proto now always has a build dependency on pbjson-build. This is
a fairly lightweight dependency and makes the logic significantly easier to
follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
