avantgardnerio commented on PR #3950: URL: https://github.com/apache/arrow-datafusion/pull/3950#issuecomment-1290784242
> What do you think about this? My main concern is about making forward progress for the project, and I think not having our dependencies install `protoc` is essential for that. Both our PRs (see [3948](https://github.com/apache/arrow-datafusion/pull/3948) accomplish that goal. My secondary concern is for general project maintainability, and for that I think there's issues either way: checked in pros: 1. it's less complex from a technical standpoint 2. it's easier to ensure docs.rs works checked in cons: 1. different versions of protoc will generate different output 3. we'll need to document how to run protoc and keep it up to date 4. formatters will create git conflicts 5. the proto files and the checked in code can get out of sync 6. users might edit the generated code accidentally generated pros: 1. the "download the binary and unzip" should be transparent to most users 2. anyone is free to use their own compiler 3. redundant derived data is not stored in source control 4. it is simpler from an operational perspective generated cons: 1. it is more complex technically 2. it requires maintenance (as does checking in) I must highlight though that I am concerned this does not resolve #3538 as that appears to be working as per my comment there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
