tustvold commented on PR #3950: URL: https://github.com/apache/arrow-datafusion/pull/3950#issuecomment-1290965838
> generated files have a formatter exception Already in place > there's clear doc on how to run protoc in a readme somewhere This is still automatically run as part of build.rs, I will add some docs though > different versions of protoc will generate different output Protoc is only used to generate a descriptor set, not the generated Rust code which is versioned by prost-build. The output should therefore be relatively stable. > dependents don't have to install protoc I suspect dependencies by git sha may still need protoc installed - as this is effectively a source dependency I think this is fine > We should have CI prevent that from happening I will add a CI check to here and arrow-rs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
