alamb commented on code in PR #3047:
URL: https://github.com/apache/arrow-rs/pull/3047#discussion_r1017134294


##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -590,6 +590,66 @@ impl ParquetRecordBatchReader {
     }
 }
 
+// Combine two lists of `RowSelection` return the intersection of them

Review Comment:
   I recommend we put this function in 
parquet/src/arrow/arrow_reader/selection.rs
   
   that way it is logically grouped with similar functionality as well as is in 
the same module as the test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to