Ted-Jiang commented on code in PR #3047:
URL: https://github.com/apache/arrow-rs/pull/3047#discussion_r1018602077
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -590,6 +590,66 @@ impl ParquetRecordBatchReader {
}
}
+// Combine two lists of `RowSelection` return the intersection of them
Review Comment:
> Perhaps you could extend
>
>
https://github.com/apache/arrow-rs/blob/4f525fe/parquet/src/arrow/arrow_reader/mod.rs#L46
>
> ```rust
> pub use selection::{RowSelection, RowSelector};
> ```
>
> to
>
> ```rust
> pub use selection::{intersect_row_selections, RowSelection, RowSelector};
> ```
>
> So it is exposed?
@alamb 😂 yes, thanks notice its ok only one method in one private mod
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
