[GitHub] [arrow-rs] Ted-Jiang commented on a diff in pull request #3047: Move `intersect_row_selections` from datafusion to arrow-rs.

Wed, 09 Nov 2022 18:42:19 -0800 


Ted-Jiang commented on code in PR #3047:
URL: https://github.com/apache/arrow-rs/pull/3047#discussion_r1018599235


##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -590,6 +590,66 @@ impl ParquetRecordBatchReader {
     }
 }
 
+// Combine two lists of `RowSelection` return the intersection of them

Review Comment:
   > Or perhaps we could rework this method as a member function on 
RowSelection? i.e. `fn intersection(&self, other: &RowSelection) -> 
RowSelection` ?
   
   This is a good idea , but it may call `from(selectors: Vec<RowSelector>)` 
more times🤔



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to