bkietz commented on code in PR #14659:
URL: https://github.com/apache/arrow/pull/14659#discussion_r1024285760
##########
cpp/src/arrow/compute/exec/expression_test.cc:
##########
@@ -258,10 +292,11 @@ TEST(Expression, ToString) {
EXPECT_EQ(literal(std::make_shared<BinaryScalar>(Buffer::FromString("az"))).ToString(),
"\"617A\"");
- auto ts = *MakeScalar("1990-10-23
10:23:33")->CastTo(timestamp(TimeUnit::NANO));
- EXPECT_EQ(literal(ts).ToString(), "1990-10-23 10:23:33.000000000");
+ using namespace arrow_literals;
Review Comment:
I was trying to keep the scope of the literals contained. As it is, not even
this was contained enough for lint
https://github.com/apache/arrow/actions/runs/3481185552/jobs/5821942926#step:5:903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
