bkietz commented on code in PR #14659:
URL: https://github.com/apache/arrow/pull/14659#discussion_r1024391590
##########
cpp/src/arrow/compute/exec/expression.cc:
##########
@@ -634,6 +634,20 @@ std::optional<Out> FoldLeft(It begin, It end, const BinOp&
bin_op) {
return folded;
}
+template <typename BinOp, typename It,
+ typename Value = typename std::iterator_traits<It>::value_type,
+ typename Out = decltype(std::declval<BinOp>()(std::declval<Value>(),
+
std::declval<Value>()))>
+std::optional<Out> MaybeFoldLeft(It begin, It end, const BinOp& bin_op) {
Review Comment:
It is the same as std::accumulate. I'll just remove these helpers; they
don't add much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
