pitrou commented on code in PR #14659:
URL: https://github.com/apache/arrow/pull/14659#discussion_r1025575040
##########
cpp/src/arrow/datum.h:
##########
@@ -116,6 +117,27 @@ struct ARROW_EXPORT Datum {
explicit Datum(std::string value);
explicit Datum(const char* value);
+ // Convenience constructors for a DurationScalar from
std::chrono::nanoseconds
Review Comment:
Why put this in Datum instead of Scalar or even DurationScalar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
