askoa commented on PR #3158: URL: https://github.com/apache/arrow-rs/pull/3158#issuecomment-1323850323
> I wonder if instead of `MutableBuffer: Clone` and adding `finish_cloned` to `BufferBuilder`, etc... we could just make use of https://docs.rs/arrow-buffer/latest/arrow_buffer/struct.Buffer.html#method.from_slice_ref? > > e.g. > > ``` > let buffer = Buffer::from_slice_ref(self.values_builder.as_slice()); > ``` > > What do you think? I made the change locally and getting below error Error for BooleanBufferBuilder: ``` "the size for values of type `[u8]` cannot be known at compilation time\nthe trait `Sized` is not implemented for `[u8]`" ``` Error for BufferBuilder: ``` "the size for values of type `[T]` cannot be known at compilation time\nthe trait `Sized` is not implemented for `[T]`" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
