tustvold commented on code in PR #3158:
URL: https://github.com/apache/arrow-rs/pull/3158#discussion_r1030119748
##########
arrow-array/src/builder/fixed_size_list_builder.rs:
##########
@@ -140,6 +146,42 @@ where
FixedSizeListArray::from(array_data)
}
+
+ /// Builds the [`FixedSizeListBuilder`] without resetting the builder.
+ pub fn finish_cloned(&self) -> FixedSizeListArray {
+ let len = self.len();
+ let values_arr = self
+ .values_builder
+ .as_any()
+ .downcast_ref::<T>()
+ .unwrap()
+ .finish_cloned();
Review Comment:
```suggestion
let values_arr = self.values_builder.finish_cloned();
```
##########
arrow-array/src/builder/map_builder.rs:
##########
@@ -152,6 +153,58 @@ impl<K: ArrayBuilder, V: ArrayBuilder> MapBuilder<K, V> {
MapArray::from(array_data)
}
+
+ pub fn finish_cloned(&self) -> MapArray {
+ let len = self.len();
+
+ // Build the keys
+ let keys_arr = self
+ .key_builder
+ .as_any()
+ .downcast_ref::<K>()
+ .unwrap()
+ .finish_cloned();
+ let values_arr = self
+ .value_builder
+ .as_any()
+ .downcast_ref::<V>()
+ .unwrap()
+ .finish_cloned();
Review Comment:
```suggestion
let keys_arr = self.key_builder.finish_cloned();
let values_arr = self.value_builder.finish_cloned();
```
##########
arrow-array/src/builder/fixed_size_list_builder.rs:
##########
@@ -140,6 +146,42 @@ where
FixedSizeListArray::from(array_data)
}
+
+ /// Builds the [`FixedSizeListBuilder`] without resetting the builder.
+ pub fn finish_cloned(&self) -> FixedSizeListArray {
+ let len = self.len();
+ let values_arr = self
+ .values_builder
+ .as_any()
+ .downcast_ref::<T>()
+ .unwrap()
+ .finish_cloned();
+ let values_data = values_arr.data();
+
+ assert!(
+ values_data.len() == len * self.list_len as usize,
Review Comment:
```suggestion
assert_eq!(
values_data.len(), len * self.list_len as usize,
```
##########
arrow-array/src/builder/generic_list_builder.rs:
##########
@@ -143,6 +149,39 @@ where
GenericListArray::<OffsetSize>::from(array_data)
}
+ /// Builds the [`GenericListArray`] without resetting the builder.
+ pub fn finish_cloned(&self) -> GenericListArray<OffsetSize> {
+ let len = self.len();
+ let values_arr = self
+ .values_builder
+ .as_any()
+ .downcast_ref::<T>()
+ .unwrap()
+ .finish_cloned();
Review Comment:
```suggestion
let values_arr = self.values_builder.finish_cloned();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
