tustvold commented on PR #3158:
URL: https://github.com/apache/arrow-rs/pull/3158#issuecomment-1324073891

   > Edit: I think finish_cloned function needs to be added to 
null_buffer_builder as null_buffer_builder.bitmap_builder might not be 
accessible outside the struct.
   
   I'd suggest adding something like
   
   ```
       /// Returns the packed bits
       pub fn as_slice(&self) -> Option<&[u8]> {
           Some(self.bitmap_builder?.as_slice())
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to