askoa commented on code in PR #3158:
URL: https://github.com/apache/arrow-rs/pull/3158#discussion_r1030420833
##########
arrow-array/src/builder/union_builder.rs:
##########
@@ -47,6 +47,8 @@ trait FieldDataValues: std::fmt::Debug {
fn append_null(&mut self);
fn finish(&mut self) -> Buffer;
+
+ fn finish_cloned(&self) -> Buffer;
Review Comment:
Though I added `build_cloned` function, I am not sure if it's required. The
existing function `build` has a signature `(self)` which means the builder
cannot be reused after calling the function. So there is no need to add
`build_cloned` which does not reset the builder. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
