jorisvandenbossche commented on code in PR #14839:
URL: https://github.com/apache/arrow/pull/14839#discussion_r1040681137
##########
docs/source/_templates/layout.html:
##########
@@ -26,3 +26,9 @@
{# Silence the navbar #}
{% block docs_navbar %}
{% endblock %}
+
+{# Add version warnings #}
+{% block footer %}
+ {{ super() }}
+ <script type="text/javascript" src="/docs/versionwarning.js"></script>
Review Comment:
The question we have to answer here is whether we want to maintain this
`versionwarning.js` file in the arrow repo or in the arrow-site repo.
Because if we put it in `_static`, that folder is created by the output of
sphinx, and so then we should include `versionwarning.js` in the sphinx source
here in the arrow repo. On the other hand, if the goal is that it is a single
file that supports all the different versions we currently include in the /docs
in arrow-site, we can also maintain it in arrow-site (and if we maintain it
there, I think it is easier to to put it in /docs instead of /docs/_static).
This is the approach that mne-python and scikit-learn (on which the current
versionwarning.js file is based) are using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
