jorisvandenbossche commented on code in PR #14839:
URL: https://github.com/apache/arrow/pull/14839#discussion_r1041913186
##########
docs/source/_templates/layout.html:
##########
@@ -26,3 +26,9 @@
{# Silence the navbar #}
{% block docs_navbar %}
{% endblock %}
+
+{# Add version warnings #}
+{% block footer %}
+ {{ super() }}
+ <script type="text/javascript" src="/docs/versionwarning.js"></script>
Review Comment:
Ah, yes, that's a good point. I agree that we should avoid having the source
only in the asf-site branch. I suppose that in theory we could still have the
file in the arrow-site repo in the master branch and ensure this gets put in
the docs/ repo on deployment. But that's also some additional complexity, so I
suppose then we can just as well leave it in the arrow repo (where at least it
lives in the docs/ repo).
We will just have to remember that whenever we want to do an update to the
versionwarning.js file, we also have to port that patch to arrow-site to
actually start using it (otherwise it only gets used once there is a new
release)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
