MichaelScofield commented on code in PR #4553:
URL: https://github.com/apache/arrow-datafusion/pull/4553#discussion_r1045378225


##########
datafusion/sql/src/planner.rs:
##########
@@ -5348,6 +5363,27 @@ mod tests {
         quick_test(sql, expected);
     }
 
+    #[test]
+    fn udaf_as_window_func() -> Result<()> {
+        let my_max = create_udaf(
+            "my_max",
+            DataType::Int32,
+            Arc::new(DataType::Int32),
+            Volatility::Immutable,
+            Arc::new(|_| 
Ok(Box::new(MaxAccumulator::try_new(&DataType::Int32)?))),

Review Comment:
   I've created a new udaf in testing codes and get rid of 
`datafusion-physical-expr` in dev-depencency. However, to write udaf (and other 
tests), I have to dependent on `datafusion-core`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to