alamb commented on code in PR #4553:
URL: https://github.com/apache/arrow-datafusion/pull/4553#discussion_r1045904460
##########
datafusion/proto/src/to_proto.rs:
##########
@@ -546,8 +551,8 @@ impl TryFrom<&Expr> for protobuf::LogicalExprNode {
protobuf::BuiltInWindowFunction::from(fun).into(),
)
}
- // TODO(LFC): Implement user-defined aggregate window
function proto ser/de.
- WindowFunction::AggregateUDF(_) => todo!()
+ // TODO: Tracked in
https://github.com/apache/arrow-datafusion/issues/4584
+ WindowFunction::AggregateUDF(_) => return
Err(Error::NotImplemented("UDAF as window function in proto".to_string()))
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
