MichaelScofield commented on PR #4553:
URL:
https://github.com/apache/arrow-datafusion/pull/4553#issuecomment-1345828960
@ozankabak thx for your comment! In fact, I was first wrote the codes just
like you said, that keep the `WindowFunction::from_str`. However, after second
thought, I think it might cause some mis-understanding (or "gotcha!")
to the readers that, since `WindowFunction` now have a `AggregateUDF`
variant, callers might have the expectation that `from_str` could return the
udaf, which is not able to, because udaf are store in some context that is not
visible here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
