Ted-Jiang commented on code in PR #4616:
URL: https://github.com/apache/arrow-datafusion/pull/4616#discussion_r1048369791
##########
datafusion/core/benches/window_query_sql.rs:
##########
@@ -222,6 +222,20 @@ fn criterion_benchmark(c: &mut Criterion) {
})
},
);
+
+ c.bench_function(
+ "window order by, u64_narrow, sum functions",
+ |b| {
+ b.iter(|| {
+ query(
+ ctx.clone(),
+ "SELECT \
Review Comment:
From the bench result:
```
Benchmarking window order by, u64_narrow, sum functions: Warming up for
3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase
target time to 35.0s, or reduce sample count to 10.
Benchmarking window order by, u64_narrow, sum functions: Collecting 100
samples in estimated 35.003 s (
window order by, u64_narrow, sum functions
time: [352.75 ms 354.80 ms 356.74 ms]
change: [-51.405% -50.834% -50.291%] (p = 0.00 <
0.05)
Performance has improved.
Found 16 outliers among 100 measurements (16.00%)
1 (1.00%) low severe
10 (10.00%) low mild
5 (5.00%) high mild
```
I change `Sum` with `sliding window` to use segment-tree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
