mustafasrepo commented on PR #4616: URL: https://github.com/apache/arrow-datafusion/pull/4616#issuecomment-1352902739
@berkaycpp is working on a [PR](https://github.com/synnada-ai/arrow-datafusion/pull/29) to support `MIN`, `MAX` with custom window frames. Thinking about how to utilize existing API lead us to use design in the [discussion](https://stackoverflow.com/questions/4802038/implement-a-queue-in-which-push-rear-pop-front-and-get-min-are-all-consta). I think this PR will be ready in a couple of days (Main components are already there, it needs minor refactors). I think implementation in this [PR](https://github.com/synnada-ai/arrow-datafusion/pull/29) is better design for future (both in terms of algorithmic complexity[it is an amortized constant algorithm and uses finite memory] and readability). @alamb What do you think about this discussion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
