[GitHub] [arrow-datafusion] Ted-Jiang commented on a diff in pull request #4616: [window function] support min max with self define sliding window and optimize segment tree .

Wed, 14 Dec 2022 04:07:25 -0800 


Ted-Jiang commented on code in PR #4616:
URL: https://github.com/apache/arrow-datafusion/pull/4616#discussion_r1048389977


##########
datafusion/core/benches/window_query_sql.rs:
##########
@@ -222,6 +222,20 @@ fn criterion_benchmark(c: &mut Criterion) {
             })
         },
     );
+
+    c.bench_function(
+        "window order by, u64_narrow, sum functions",
+        |b| {
+            b.iter(|| {
+                query(
+                    ctx.clone(),
+                    "SELECT \

Review Comment:
   Remove `Sum`, it may cause overflow 😩



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to