tustvold opened a new pull request, #3365:
URL: https://github.com/apache/arrow-rs/pull/3365
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Part of #3338
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
```
4096 u64(0) - 128 time: [360.72 µs 360.87 µs 361.05 µs]
change: [-23.673% -23.491% -23.370%] (p = 0.00 <
0.05)
Performance has improved.
Found 8 outliers among 100 measurements (8.00%)
6 (6.00%) high mild
2 (2.00%) high severe
4096 u64(0) - 1024 time: [331.16 µs 331.27 µs 331.38 µs]
change: [-48.717% -48.649% -48.543%] (p = 0.00 <
0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe
4096 u64(0) - 4096 time: [330.40 µs 330.53 µs 330.71 µs]
change: [-75.546% -75.482% -75.444%] (p = 0.00 <
0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
4 (4.00%) high mild
1 (1.00%) high severe
4096 i64(0) - 128 time: [356.13 µs 356.22 µs 356.32 µs]
change: [-25.166% -25.142% -25.120%] (p = 0.00 <
0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild
4096 i64(0) - 1024 time: [328.21 µs 328.32 µs 328.43 µs]
change: [-48.985% -48.896% -48.843%] (p = 0.00 <
0.05)
Performance has improved.
4096 i64(0) - 4096 time: [327.60 µs 327.77 µs 327.94 µs]
change: [-75.634% -75.622% -75.610%] (p = 0.00 <
0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild
4096 f32(0) - 128 time: [293.13 µs 293.22 µs 293.31 µs]
change: [-26.308% -26.126% -25.945%] (p = 0.00 <
0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) low mild
2 (2.00%) high mild
1 (1.00%) high severe
4096 f32(0) - 1024 time: [265.46 µs 265.52 µs 265.59 µs]
change: [-50.188% -50.037% -49.897%] (p = 0.00 <
0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe
4096 f32(0) - 4096 time: [266.15 µs 266.23 µs 266.32 µs]
change: [-75.647% -75.632% -75.618%] (p = 0.00 <
0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
4 (4.00%) high mild
2 (2.00%) high severe
4096 f64(0) - 128 time: [316.88 µs 316.95 µs 317.03 µs]
change: [-25.096% -24.949% -24.860%] (p = 0.00 <
0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
1 (1.00%) low mild
5 (5.00%) high mild
3 (3.00%) high severe
4096 f64(0) - 1024 time: [285.10 µs 285.16 µs 285.23 µs]
change: [-51.985% -51.965% -51.946%] (p = 0.00 <
0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
5 (5.00%) high mild
5 (5.00%) high severe
4096 f64(0) - 4096 time: [285.62 µs 285.72 µs 285.84 µs]
change: [-77.933% -77.901% -77.848%] (p = 0.00 <
0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
2 (2.00%) high mild
3 (3.00%) high severe
4096 string(10, 0) - 128
time: [163.92 µs 163.96 µs 164.00 µs]
change: [-37.060% -37.015% -36.956%] (p = 0.00 <
0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) high mild
3 (3.00%) high severe
4096 string(10, 0) - 1024
time: [127.45 µs 127.49 µs 127.54 µs]
change: [-67.408% -67.348% -67.247%] (p = 0.00 <
0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) high mild
3 (3.00%) high severe
4096 string(10, 0) - 4096
time: [125.65 µs 125.71 µs 125.77 µs]
change: [-86.901% -86.880% -86.842%] (p = 0.00 <
0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe
4096 string(30, 0) - 128
time: [225.21 µs 225.25 µs 225.30 µs]
change: [-31.578% -31.423% -31.306%] (p = 0.00 <
0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe
4096 string(30, 0) - 1024
time: [182.79 µs 182.88 µs 182.98 µs]
change: [-64.628% -64.497% -64.342%] (p = 0.00 <
0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) high mild
3 (3.00%) high severe
4096 string(30, 0) - 4096
time: [183.36 µs 183.43 µs 183.52 µs]
change: [-84.714% -84.702% -84.691%] (p = 0.00 <
0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
4 (4.00%) high mild
3 (3.00%) high severe
4096 string(100, 0) - 128
time: [490.86 µs 491.27 µs 491.70 µs]
change: [-19.107% -18.963% -18.816%] (p = 0.00 <
0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
4 (4.00%) high mild
1 (1.00%) high severe
4096 string(100, 0) - 1024
time: [445.64 µs 445.85 µs 446.07 µs]
change: [-49.217% -49.155% -49.065%] (p = 0.00 <
0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe
4096 string(100, 0) - 4096
time: [490.16 µs 490.55 µs 490.89 µs]
change: [-75.088% -75.052% -75.012%] (p = 0.00 <
0.05)
Performance has improved.
Found 26 outliers among 100 measurements (26.00%)
15 (15.00%) low severe
3 (3.00%) low mild
5 (5.00%) high mild
3 (3.00%) high severe
4096 string(100, 0.5) - 128
time: [357.47 µs 357.56 µs 357.66 µs]
change: [-27.187% -27.017% -26.761%] (p = 0.00 <
0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
5 (5.00%) high mild
4 (4.00%) high severe
4096 string(100, 0.5) - 1024
time: [316.25 µs 316.36 µs 316.49 µs]
change: [-58.868% -58.846% -58.827%] (p = 0.00 <
0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe
4096 string(100, 0.5) - 4096
time: [325.66 µs 325.82 µs 326.00 µs]
change: [-77.121% -77.107% -77.094%] (p = 0.00 <
0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe
Benchmarking 4096 string(20, 0.5), string(30, 0), string(100, 0), i64(0) -
128: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase
target time to 5.9s, enable flat sampling, or reduce sample count to 60.
4096 string(20, 0.5), string(30, 0), string(100, 0), i64(0) - 128
time: [1.1570 ms 1.1576 ms 1.1583 ms]
change: [-18.339% -18.157% -17.945%] (p = 0.00 <
0.05)
Performance has improved.
Found 19 outliers among 100 measurements (19.00%)
3 (3.00%) high mild
16 (16.00%) high severe
Benchmarking 4096 string(20, 0.5), string(30, 0), string(100, 0), i64(0) -
1024: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase
target time to 5.1s, enable flat sampling, or reduce sample count to 60.
4096 string(20, 0.5), string(30, 0), string(100, 0), i64(0) - 1024
time: [1.0139 ms 1.0146 ms 1.0154 ms]
change: [-35.902% -35.849% -35.794%] (p = 0.00 <
0.05)
Performance has improved.
Found 23 outliers among 100 measurements (23.00%)
7 (7.00%) low severe
7 (7.00%) low mild
4 (4.00%) high mild
5 (5.00%) high severe
Benchmarking 4096 string(20, 0.5), string(30, 0), string(100, 0), i64(0) -
4096: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase
target time to 5.3s, enable flat sampling, or reduce sample count to 60.
4096 string(20, 0.5), string(30, 0), string(100, 0), i64(0) - 4096
time: [1.0514 ms 1.0524 ms 1.0535 ms]
change: [-63.795% -63.754% -63.713%] (p = 0.00 <
0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
4096 string(20, 0.5), string(30, 0), f64(0), i64(0) - 128
time: [941.30 µs 941.55 µs 941.85 µs]
change: [-21.932% -21.887% -21.842%] (p = 0.00 <
0.05)
Performance has improved.
Found 9 outliers among 100 measurements (9.00%)
5 (5.00%) high mild
4 (4.00%) high severe
4096 string(20, 0.5), string(30, 0), f64(0), i64(0) - 1024
time: [802.95 µs 803.27 µs 803.65 µs]
change: [-40.134% -40.095% -40.059%] (p = 0.00 <
0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
5 (5.00%) high mild
2 (2.00%) high severe
4096 string(20, 0.5), string(30, 0), f64(0), i64(0) - 4096
time: [813.42 µs 813.84 µs 814.26 µs]
change: [-66.732% -66.690% -66.632%] (p = 0.00 <
0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe
```
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Adds a custom record reader based on csv-core, that significantly reduces
allocations whilst parsing arrow data.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
