tustvold commented on code in PR #3365:
URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1051686401
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -723,34 +675,26 @@ fn parse_bool(string: &str) -> Option<bool> {
// parse the column string to an Arrow Array
fn build_decimal_array(
_line_number: usize,
- rows: &[StringRecord],
+ rows: &StringRecords<'_>,
col_idx: usize,
precision: u8,
scale: i8,
) -> Result<ArrayRef, ArrowError> {
let mut decimal_builder = Decimal128Builder::with_capacity(rows.len());
- for row in rows {
Review Comment:
We now more strictly enforce that the schema actually matches the data read,
I don't think it was a documented behaviour that rows could be missing fields,
and I think largely an implementation quirk, but I think it is worth
highlighting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
