tustvold commented on code in PR #3365:
URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1051685710
##########
arrow-csv/src/reader/mod.rs:
##########
@@ -383,6 +417,7 @@ impl<R: Read> Reader<R> {
/// This constructor allows you more flexibility in what records are
processed by the
/// csv reader.
#[allow(clippy::too_many_arguments)]
+ #[deprecated(note = "Use Reader::new or ReaderBuilder")]
Review Comment:
Having two methods `from_reader` and `new` with identical signatures is a
touch confusing. Let's just unify them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
