jgehrcke commented on PR #15049: URL: https://github.com/apache/arrow/pull/15049#issuecomment-1359659787
Thank you Alenka! :) > did you plan to update/correct the documentation also (as Weston suggested https://github.com/apache/arrow/issues/14968#issuecomment-1355542182)? I looked a bit for "the DefaultWriteOptions comment docs" and did not find those quickly, so I opted for adding the documenting comment to where `DefaultWriteOptions()` is called. Is this `\brief ...` what Weston was referring to? https://github.com/apache/arrow/blob/d18412e07f5aad968a73e1f44bcfa0c63461211f/cpp/src/arrow/dataset/file_base.h#L203 > You could also skip the test with a pytest mark, like here: Oh, thanks for the pointer! Does our CI invoke pytest with `-m "not orc"` to deselect those tests when testing a build without ORC support? Or would the user need to manually add `-m "not orc"`? In case of the win32 CI run (which AFAIU did not use a pyarrow build with ORC support) the pytest cmd is `py.test -r sxX --durations=15 --pyargs pyarrow.tests`. And yet, all tests in `test_orc.py` are skipped (`pyarrow\tests\test_orc.py sssssssssssss `. I had a quick look but didn't find the magic responsible for that. In other words: what's the magic that _automatically_ deselects orc-marked tests whenever necessary? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
