AlenkaF commented on PR #15049: URL: https://github.com/apache/arrow/pull/15049#issuecomment-1360929882
> I looked a bit for "the DefaultWriteOptions comment docs" and did not find those quickly, so I opted for adding the documenting comment to where `DefaultWriteOptions()` is called. > > Is this `\brief ...` what Weston was referring to? I would add a note in the: https://arrow.apache.org/docs/dev/cpp/api/dataset.html#_CPPv4N5arrow7dataset13OrcFileFormat19DefaultWriteOptionsEv and maybe make the orc support in the dataset more explicit in the C++ and Python documentation (as you have mentioned in the issue): https://arrow.apache.org/docs/dev/cpp/dataset.html https://arrow.apache.org/docs/python/dataset.html > Oh, thanks for the pointer! Does our CI invoke pytest with `-m "not orc"` to deselect those tests when testing a build without ORC support? Or would the user need to manually add `-m "not orc"`? > > In case of the win32 CI run (which AFAIU did not use a pyarrow build with ORC support) the pytest cmd [is](https://github.com/apache/arrow/blob/d18412e07f5aad968a73e1f44bcfa0c63461211f/ci/appveyor-cpp-build.bat#L130) `py.test -r sxX --durations=15 --pyargs pyarrow.tests`. And yet, all tests in `test_orc.py` are skipped (`pyarrow\tests\test_orc.py sssssssssssss `. I had a quick look but didn't find the magic responsible for that. In other words: what's the magic that _automatically_ deselects orc-marked tests whenever necessary? You can get the info about it in these two conftest files 🪄 😉 https://github.com/apache/arrow/blob/5e25af8860e3859bb4d17f22e4dbaa2309e5076d/python/pyarrow/tests/conftest.py#L48-L70 https://github.com/apache/arrow/blob/5e25af8860e3859bb4d17f22e4dbaa2309e5076d/python/pyarrow/conftest.py#L22-L82 > Btw, when looking at https://github.com/apache/arrow/blob/d18412e07f5aad968a73e1f44bcfa0c63461211f/ci/appveyor-cpp-build.bat I see that the c++ lib has -DARROW_ORC=ON but the pyarrow build does not have the corresponding PYARROW_WITH_ORC=ON -- is that intentional? I am not sure about that. I would suspect it just wasn't added to the Win CI build yet as I haven't found any issue with CI failures due to `PYARROW_WITH_ORC=ON` in Jira 🤷♀️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
