kou commented on code in PR #15049:
URL: https://github.com/apache/arrow/pull/15049#discussion_r1055833225
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -200,6 +200,9 @@ class ARROW_DS_EXPORT FileFormat : public
std::enable_shared_from_this<FileForma
fs::FileLocator destination_locator) const = 0;
/// \brief Get default write options for this format.
+ ///
+ /// May return nullptr if this file format does not yet support writing
Review Comment:
> and decided to
>
> ```c++
> return std::shared_ptr<FileWriteOptions>(nullptr);
> ```
>
> I think that's what you meant, right? I like that this is explicit.
Pushing a commit.
Ah, sorry. I didn't meant that we should change the existing code. I just
meant that we can improve the added comment:
```suggestion
/// May return empty shared_ptr if this file format does not yet support
writing
```
Could you revert the `return std::shared_ptr<FileWriteOptions>(nullptr);`
change in this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
