liukun4515 commented on code in PR #4711:
URL: https://github.com/apache/arrow-datafusion/pull/4711#discussion_r1057109998
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -237,6 +238,7 @@ impl Optimizer {
let rules: Vec<Arc<dyn OptimizerRule + Sync + Send>> = vec![
Arc::new(InlineTableScan::new()),
Arc::new(TypeCoercion::new()),
+ Arc::new(ExtractEquijoinPredicate::new()),
Review Comment:
Some subquery will be converted to the join in the following up
`SubqueryFilterToJoin` rule., and I am not sure if this rule is right in this
position
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -237,6 +238,7 @@ impl Optimizer {
let rules: Vec<Arc<dyn OptimizerRule + Sync + Send>> = vec![
Arc::new(InlineTableScan::new()),
Arc::new(TypeCoercion::new()),
+ Arc::new(ExtractEquijoinPredicate::new()),
Review Comment:
cc @ygf11 @jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
