[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #4711: Move the extract_join_keys to optimizer

Mon, 26 Dec 2022 00:41:12 -0800 


liukun4515 commented on code in PR #4711:
URL: https://github.com/apache/arrow-datafusion/pull/4711#discussion_r1057138364


##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -237,6 +238,7 @@ impl Optimizer {
         let rules: Vec<Arc<dyn OptimizerRule + Sync + Send>> = vec![
             Arc::new(InlineTableScan::new()),
             Arc::new(TypeCoercion::new()),
+            Arc::new(ExtractEquijoinPredicate::new()),

Review Comment:
   > Yes, this rule should be placed behind `SubqueryFilterToJoin` rule. 
@jackwener also suggested about it in [#4725 
(comment)](https://github.com/apache/arrow-datafusion/pull/4725#discussion_r1056956986).
   > 
   > I think it is ok now, because `SubqueryFilterToJoin` and other similar 
rule directly specify the equijoin predicate, so they do not depends 
`ExtractEquijoinPredicate` currently.
   
   Yes, other rule will convert query to join with specified equal-join 
predicate and non-equal-join predicate.
   
   > I plan to do this movement after #4725 merged.
   
   LGTM
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to