ygf11 commented on code in PR #4711:
URL: https://github.com/apache/arrow-datafusion/pull/4711#discussion_r1057128201
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -237,6 +238,7 @@ impl Optimizer {
let rules: Vec<Arc<dyn OptimizerRule + Sync + Send>> = vec![
Arc::new(InlineTableScan::new()),
Arc::new(TypeCoercion::new()),
+ Arc::new(ExtractEquijoinPredicate::new()),
Review Comment:
Yes, this rule should be placed behind `SubqueryFilterToJoin` rule.
@jackwener also suggested about it in
https://github.com/apache/arrow-datafusion/pull/4725#discussion_r1056956986.
But I think it is ok now, because `SubqueryFilterToJoin` and other similar
rule directly specify the equijoin predicate, so they do not depends
`ExtractEquijoinPredicate` currently.
I plan to do this movement after #4725 merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
