liukun4515 commented on code in PR #4741:
URL: https://github.com/apache/arrow-datafusion/pull/4741#discussion_r1058275060
##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -575,6 +575,7 @@ fn temporal_coercion(lhs_type: &DataType, rhs_type:
&DataType) -> Option<DataTyp
},
(Timestamp(_, tz), Utf8) => Some(Timestamp(TimeUnit::Nanosecond,
tz.clone())),
(Utf8, Timestamp(_, tz)) => Some(Timestamp(TimeUnit::Nanosecond,
tz.clone())),
+ // TODO: need to investigate the result type for the comparison
between timestamp and date
Review Comment:
> @liukun4515 comparison is usually boolean type, did you mean what is the
common datatype for casting between timestamp and date in diff scenarios?
I think it's not about `casting` from one type to other type, it is related
the `type inference` for different input types and different operation or
functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
