alamb commented on code in PR #4741:
URL: https://github.com/apache/arrow-datafusion/pull/4741#discussion_r1058309797
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -177,35 +177,12 @@ pub fn can_coerce_from(type_into: &DataType, type_from:
&DataType) -> bool {
Timestamp(TimeUnit::Nanosecond, None) => {
matches!(type_from, Null | Timestamp(_, None))
}
- Date32 => {
- matches!(type_from, Null | Timestamp(_, None))
- }
Utf8 | LargeUtf8 => true,
Null => can_cast_types(type_from, type_into),
_ => false,
}
}
-/// Returns a common coerced datatype between 2 given datatypes
-///
-/// See the module level documentation for more detail on coercion.
-pub fn get_common_coerced_type(
Review Comment:
Let's merge this PR then -- we can always recover `get_common_coerced_type`
from this PR or git history if we need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
