mustafasrepo commented on code in PR #4777:
URL: https://github.com/apache/arrow-datafusion/pull/4777#discussion_r1061179316
##########
datafusion/core/src/physical_plan/common.rs:
##########
@@ -95,6 +96,47 @@ pub async fn collect(stream: SendableRecordBatchStream) ->
Result<Vec<RecordBatc
.map_err(DataFusionError::from)
}
+/// Merge two record batch references into a single record batch.
+/// All the record batches inside the slice must have the same schema.
+pub fn merge_batches(
Review Comment:
`concat_batches` receives argument `&[RecordBatch]` in this API ownership
passes to vector. However, in our API we receive &RecordBatch. Hence we do not
need to pass ownership. If there were a variant of `concat_batches` receiving
&[&RecordBatch] we could have use it instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
