mustafasrepo commented on code in PR #4777:
URL: https://github.com/apache/arrow-datafusion/pull/4777#discussion_r1061313487
##########
datafusion/physical-expr/src/window/aggregate.rs:
##########
@@ -162,4 +162,12 @@ impl WindowExpr for AggregateWindowExpr {
}
})
}
+
+ fn uses_bounded_memory(&self) -> bool {
+ // NOTE: Currently, groups queries do not support the bounded memory
variant.
Review Comment:
You are right, for some cases data will never fit bounded memory. However,
conceptually they can be treated bounded. I think there is no obstacle
implementation-wise for running GROUP queries with bounded exec. In the
follow-up PRs we will experiment with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
